On Tue, 16 Mar 2004 15:06:59 -0800 David Brownell <[EMAIL PROTECTED]> wrote:
> Need to initialize timers a bit earlier to handle > certain initialization faults. > > Please merge. > --- 1.69/drivers/usb/host/ehci-hcd.c Fri Feb 20 11:20:07 2004 > +++ edited/drivers/usb/host/ehci-hcd.c Wed Feb 25 09:04:11 2004 > @@ -374,6 +374,10 @@ > u32 hcc_params; > u8 tempbyte; > > + init_timer (&ehci->watchdog); > + ehci->watchdog.function = ehci_watchdog; > + ehci->watchdog.data = (unsigned long) ehci; > + > /* > * hw default: 1K periodic list heads, one per frame. > * periodic_size can shrink by USBCMD update if hcc_params allows. NO, NO, NO! This is a very bad idea. You are supposed to call init_timer once, and never again. OK, the old code did it, but it's not an excuse. -- Pete ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
