On Saturday 20 of March 2004 22:48, Greg KH wrote:
> On Sat, Mar 20, 2004 at 10:33:36PM +0100, Domen Puncer wrote:
> > Hi.
> >
> > This is my first patch on sleep_on, so i'd really like some comments.
>
> Please cc the linux-usb-devel list, they will help you out too
> (hopefully...)
Comments and patch again, for the linux-usb-devel people...
Is wait_event(wq, 0) fine, if we are just waiting for wake_up?
Second one is just waiting 3 seconds, so i removed wq.
Domen
--- c/drivers/usb/media/usbvideo.c 2003-12-18 03:59:59.000000000 +0100
+++ a/drivers/usb/media/usbvideo.c 2004-03-20 17:46:58.000000000 +0100
@@ -225,7 +225,7 @@
static void RingQueue_InterruptibleSleepOn(struct RingQueue *rq)
{
assert(rq != NULL);
- interruptible_sleep_on(&rq->wqh);
+ wait_event_interruptible(&rq->wqh, 0);
}
void RingQueue_WakeUpInterruptible(struct RingQueue *rq)
@@ -705,10 +705,9 @@
/* Debugging aid */
void usbvideo_SayAndWait(const char *what)
{
- wait_queue_head_t wq;
- init_waitqueue_head(&wq);
info("Say: %s", what);
- interruptible_sleep_on_timeout (&wq, HZ*3); /* Timeout */
+ set_current_state(TASK_INTERRUPTIBLE);
+ schedule_timeout(HZ*3);
}
EXPORT_SYMBOL(usbvideo_SayAndWait);
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
