Hi,
some error codes are incorrect and there's an URB leak in an error path.
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
===================================================================
[EMAIL PROTECTED], 2004-03-22 19:03:08+01:00, [EMAIL PROTECTED]
- fix error return codes
- fix URB leak in error path
kobil_sct.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff -Nru a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
--- a/drivers/usb/serial/kobil_sct.c Mon Mar 22 19:10:39 2004
+++ b/drivers/usb/serial/kobil_sct.c Mon Mar 22 19:10:39 2004
@@ -262,7 +262,7 @@
// allocate memory for transfer buffer
transfer_buffer = (unsigned char *) kmalloc(transfer_buffer_length,
GFP_KERNEL);
if (! transfer_buffer) {
- return -1;
+ return -ENOMEM;
} else {
memset(transfer_buffer, 0, transfer_buffer_length);
}
@@ -274,7 +274,7 @@
if (!port->write_urb) {
dbg("%s - port %d usb_alloc_urb failed", __FUNCTION__,
port->number);
kfree(transfer_buffer);
- return -1;
+ return -ENOMEM;
}
}
@@ -282,7 +282,9 @@
port->write_urb->transfer_buffer = (unsigned char *)
kmalloc(write_urb_transfer_buffer_length, GFP_KERNEL);
if (! port->write_urb->transfer_buffer) {
kfree(transfer_buffer);
- return -1;
+ usb_free_urb(port->write_urb);
+ port->write_urb = NULL;
+ return -ENOMEM;
}
// get hardware version
===================================================================
This BitKeeper patch contains the following changesets:
1.1187
## Wrapped with gzip_uu ##
begin 664 bkpatch12384
M'XL(`"`L7T```[5476O;,!1]MG[%A;YL%-M7\K=#2M8V;&-I&[+E:[EMAIL PROTECTED]&IL
MXEA!MIL-_..G."4C(TNSL5X;KJQS='T_#KJ`:254;,@B?Q**7,`'6=6QH=>K
M)A6E58IFV:PLJ18:FTBI,3N3*V'O#MA?E!"57>1E4YG,\HAFC7F=9*#!*C:H
MY>QWZA]K$1N3X?OIZ-V$D'X?;C)>[EMAIL PROTECTED]>9X4LK5KQLEJ)
MFEN)7+5[:LL0F7X\&CCH^2WUT0W:A*:4<I>*%)D;^B[9I3<X4L=A*!<=QC!@
M`;JMCPZ-R"U0B](P`'1M=&S&@$8Q.C&&ETAC1/AS:+BD8"*YAO];RPU)8&LF
M/.;[EMAIL PROTECTED]:B.H"GDVLH!%]"7CY3USH)[EMAIL PROTECTED]:^F$_,OC1#D
[EMAIL PROTECTED],ERKEJDFRPE/.\L%+Q=:'$XEN;JFUO*KNIYK;65<X+NV/,JJ2VDJY>
MRC"B(=7IM,SS?&Q%B'[D(0;<$1BYX8D&GQ&_&[EMAIL PROTECTED]@TYII\]MY??*
M19%MJ,%229YM-7!V9!>[EMAIL PROTECTED]"G3_]0G2SVG#/4Z8'IO(HZ3RCS!55V
M$WH`4VVZ5XML_,*P_D&VM\SW@)*/.V<8SRF:P_N'N^%=3^-!T.&=,XX1PET`
M[1Q-T)G-'O7--VO4_,U:JMJ\VJB\[K[?]C3AMSWHP_UT-.H=^??^>DPRD2RK
29M6/W#D-$Q&2GTF[[I.<!0``
`
end
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
