On Tue, 23 Mar 2004, Paulo Marques wrote:
> Oliver Neukum wrote:
>
> > Hi,
> >
> > this driver is doing DMA to the stack. Here's the obvious fix.
> >
> > Regards
> > Oliver
> >
>
> Hi,
>
> In function change_speed you changed the semantics from:
>
> "return (...<0);"
>
> to
>
> "return ...;"
>
> This might break the code on line 1802:
>
> if (change_speed(port)) {
> err("%s urb failed to set baurdrate", __FUNCTION__);
>
> Was this an oversight, or is it intended (am I missing something)?
Yes, x < 0 implies that x != 0
The function cannot return a positive value.
If you return errors you should return full error information.
Regards
Oliver
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
