On Mon, Apr 26, 2004 at 04:05:17PM +0200, Duncan Sands wrote:
> diff -Nru a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> --- a/drivers/usb/core/devio.c        Mon Apr 26 13:48:28 2004
> +++ b/drivers/usb/core/devio.c        Mon Apr 26 13:48:28 2004
> @@ -350,8 +350,8 @@
>        * all pending I/O requests; 2.6 does that.
>        */
>  
> -     if (ifnum < 8*sizeof(ps->ifclaimed))
> -             clear_bit(ifnum, &ps->ifclaimed);
> +     BUG_ON(ifnum >= 8*sizeof(ps->ifclaimed));

I've changed that to a WARN_ON().  Yeah, writing over memory is bad, but
oopsing is worse.  Let's be a bit nicer than that.

thanks,

greg k-h


-------------------------------------------------------
This SF.net email is sponsored by: The Robotic Monkeys at ThinkGeek
For a limited time only, get FREE Ground shipping on all orders of $35
or more. Hurry up and shop folks, this offer expires April 30th!
http://www.thinkgeek.com/freeshipping/?cpg=12297
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to