1. (Not particularly related to anything else going on lately. Maybe I've mentioned this to you before; I don't remember.) This code in
usb_sg_init() doesn't look good:
if (dma) { ... } else { /* hc may use _only_ transfer_buffer */ io->urbs [i]->transfer_buffer = page_address (sg [i].page) + sg [i].offset;
The problem is that page_address() doesn't really work right, especially for memory pages above 1 GB.
Someone commented that kmap_atomic() is needed ... but nobody's submitted a fix. Root hubs doing PIO are rare so far (dummy_hcd, and eventually sl811hs), so the problem is low priority.
2. (Found while testing your changes to usb_reset_device) Although usbcore acquires usbdev->serialize before probing newly-attached devices, it doesn't acquire the semaphore before probing newly-registered drivers! I don't know how that should be fixed.
Erm, I think it's important to be consistent: either probe() always holds it -- like in usb_set_configuration() from khubd -- or it never does. Would anything break if usbcore grabbed usbdev->serialize in that one case?
- Dave
-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
