On Tue, 4 May 2004, Greg KH wrote: > Send all pending patches that you have generated for this to me. I'll > apply them to the tree.
This is the only one. Only one aspect of it is notable: The CPiA USB driver calls usb_driver_release_interface() during its disconnect() routine. That doesn't appear to be necessary, since it didn't call usb_driver_claim_interface() beforehand and since the interface will be released automatically when disconnect() returns. Alan Stern ===== drivers/media/video/cpia_usb.c 1.29 vs edited ===== --- 1.29/drivers/media/video/cpia_usb.c Mon Aug 4 13:46:50 2003 +++ edited/drivers/media/video/cpia_usb.c Tue Apr 27 13:54:33 2004 @@ -499,7 +499,7 @@ if (udev->descriptor.bNumConfigurations != 1) return -ENODEV; - interface = &intf->altsetting[0]; + interface = intf->cur_altsetting; printk(KERN_INFO "USB CPiA camera found\n"); @@ -620,8 +620,6 @@ wake_up_interruptible(&ucpia->wq_stream); udev = interface_to_usbdev(intf); - usb_driver_release_interface(&cpia_driver, - udev->actconfig->interface[0]); ucpia->curbuff = ucpia->workbuff = NULL; ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel