On Fri, 7 May 2004, [EMAIL PROTECTED] wrote:
> Hi All,
>
> I don't know where else to report this, but I found a very very very
> minor bug in the usb gadgets drivers, specifically the file_storage.c
> mass storage driver.
>
> In the function do_request_sense(..) it says:
>
> buf[7] = 18 - 7; // Additional sense length
>
> Whereas (according to page 38 of the USB mass storage class, UFI command spec,
> http://www.usb.org/developers/devclass_docs#approved) this clearly neads
> to be equal to 10, not 11.
>
> I checked with the 2.6.5 source, it is still there. Hope someone will find this
> usefull, although most USB hosts seem to ignore length bits alltogether anyway....
>
> Koen Martens
You are quite right; thank you for pointing this out. Greg, please apply
the patch below.
Alan Stern
===== drivers/usb/gadget/file_storage.c 1.7 vs edited =====
--- 1.7/drivers/usb/gadget/file_storage.c Thu Apr 15 12:22:31 2004
+++ edited/drivers/usb/gadget/file_storage.c Fri May 7 12:21:45 2004
@@ -2054,7 +2054,7 @@
buf[0] = 0x80 | 0x70; // Valid, current error
buf[2] = SK(sd);
put_be32(&buf[3], sdinfo); // Sense information
- buf[7] = 18 - 7; // Additional sense length
+ buf[7] = 18 - 8; // Additional sense length
buf[12] = ASC(sd);
buf[13] = ASCQ(sd);
return 18;
-------------------------------------------------------
This SF.Net email is sponsored by Sleepycat Software
Learn developer strategies Cisco, Motorola, Ericsson & Lucent use to
deliver higher performing products faster, at low TCO.
http://www.sleepycat.com/telcomwpreg.php?From=osdnemail3
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
