- hub driver won't resubmit when it's suspended
     (and re-deletes broken comment)

That last one isn't actually a build fix


This is okay for now, but I don't like it very much. For one thing, it doesn't check for the -EHOSTUNREACH code in urb->status. Anyway, the completion handler shouldn't have to worry about this stuff.

Somewhere it has to know whether to resubmit or not, and that's a simple solution for now.


The proper thing to do is have the suspend() callback use usb_kill_urb(),
in mirror symmetry to the way the resume() callback uses usb_submit_urb().

I hope you won't mind if I change it when usb_kill_urb() is finished.

Certainly, but since this didn't make Greg's push yesterday, what I think I'll do is split it all off and deal with that as part of the CONFIG_USB_SUSPEND changes. It's actually not possible to hit that code path until something starts to issue suspend() calls to the USB drivers.

- Dave




------------------------------------------------------- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to