Greg KH wrote:
Doh.  Ok, how about this?

And yes, I'll kill the usb specific version, and the other uses of
msleep in the kernel tree when I send it off to Linus.

Looks OK except for...


===== include/linux/wait.h 1.10 vs edited =====
--- 1.10/include/linux/wait.h   Sat May 15 04:50:38 2004
+++ edited/include/linux/wait.h Tue May 18 11:22:41 2004

This is a bit of an odd choice. The relationship to waitqueue problems is really only coincedental, I would think linux/sched.h or linux/time.h or linux/delay.h would be better choices.



@@ -258,6 +258,8 @@
                INIT_LIST_HEAD(&wait->task_list);                        \
        } while (0)
        
+void msleep(unsigned int msecs);

Extremely minor: I prefer 'extern' for prototypes in public headers, and you see that fairly often in include/linux.


        Jeff





-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to