Hi,
this is in kobil_sct.
It uses msleep() and replaces needless GFP_ATOMICs with GFP_NOIO
as this function can sleep.
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
===================================================================
[EMAIL PROTECTED], 2004-05-19 17:20:59+02:00, [EMAIL PROTECTED]
- no need for GFP_ATOMIC
- use msleep()
kobil_sct.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff -Nru a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
--- a/drivers/usb/serial/kobil_sct.c Wed May 19 17:21:50 2004
+++ b/drivers/usb/serial/kobil_sct.c Wed May 19 17:21:50 2004
@@ -474,14 +474,12 @@
);
priv->cur_pos = priv->cur_pos + length;
- result = usb_submit_urb( port->write_urb, GFP_ATOMIC );
+ result = usb_submit_urb( port->write_urb, GFP_NOIO );
dbg("%s - port %d Send write URB returns: %i", __FUNCTION__,
port->number, result);
todo = priv->filled - priv->cur_pos;
if (todo > 0) {
- //mdelay(16);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(24 * HZ / 1000);
+ msleep(24);
}
} // end while
@@ -493,7 +491,7 @@
port->interrupt_in_urb->dev = port->serial->dev;
// start reading
- result = usb_submit_urb( port->interrupt_in_urb, GFP_ATOMIC );
+ result = usb_submit_urb( port->interrupt_in_urb, GFP_NOIO );
dbg("%s - port %d Send read URB returns: %i", __FUNCTION__,
port->number, result);
}
return count;
===================================================================
This BitKeeper patch contains the following changesets:
1.1753
## Wrapped with gzip_uu ##
M'XL( (Y[JT \546VO;,!A]MG[%!WUIZ6)+LGP=*>G:M2N[)&3MTQA!MK78
MQ+:")+<,_.,G.Z.%A2W=V)@L$-9W/><[Z CNM%"I(^OJ7BAT!&^D-JG3\#P3
MIG1;T6VZQI5J;4U+*:W)*V4CO)V_=ZN$T-Y:B34-D759<).78"TZ=8CK/]Z8
MKUN1.LO7UW?OSI<(3:=P4?)V+3X* ],I,E+=\[K0,V[*6K:N4;S5C3#<S673
M/[KV%&-JOX!$/@["GH2817U."D(X(Z+ E,4A0T,[LXV2O-P/9S8XIGX0XK"G
MH?U#ET!<[EMAIL PROTECTED];AP",)D"BE. V24TQ3C&$'=;9/"9P2F&#T"OYN^Q<HAPFT
M$EHA"[EMAIL PROTECTED];GM_/W-SM3IP4TNA9B>WR"W@(-D\!'BR=&T>0W%T*88W0&
M#[Q4HLU4EY>SC<RJVBW$IX'-SWVA!A*TU^G,LX*I>.V-'BN=&S<?D1&*$Q*3
MD.">!I;@7L38MH9QQ'V!$Q;_G,EGI!\&EY# LD?[D-$D'%7TZ[A!6O\8TP]B
M>W;F 0X;9,=P;R'%=-0A)7LJI(=5Z,,D^.\JW,UD#A/U,&ZKJL6!\?R!3B]9
M% %!-[O#<1PE=%?;-\2VDZUTES65674J.X:M5&9R]J J(X:+%V/['^8W<SAY
M:=/$%'R;)F:[-,YW))2-UB0<BXS'P1I5:X12W=:LJG:O%#R]BGDI\HWNFBDO
._"@>1OX-EX<5PWT%
-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
