This patch creates a separate subroutine to encapsulate the work required in choosing an initial configuration for a device.
One issue: at some point Linux should be detecting some error cases there, like "not enough power available". Today that just generates a warning, like:
hub 1-1:1.0: 88mA over power budget!
That is, choose_configuration() shouldn't always succeed; the NOTE about interacting with power budgeting belongs with that routine, not in usb_new_device().
My suggestion for the moment is check for error returns in choose_configuration(), and move that NOTE about power budgeting. In fact, maybe the config choosing should move to hub.c, where it's got full access to the power budgeting info (which is hub-internal).
- Dave
+ c = usb_choose_configuration(dev); + err = usb_set_configuration(dev, c);
-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
