Oh, one comment on your recent patch submissions...

On Sun, Jun 20, 2004 at 11:33:53PM +0200, Oliver Neukum wrote:
> -----BEGIN PGP SIGNED MESSAGE-----

PGP signed patches are a pain to deal with.  In short, it just doesn't
work :(

If I take the raw message, it usually contains mime attachments (like
the ones that Matt keeps sending me.)  I can deal with that as I have
tools for it.

But your mailer likes to change the text of the patch, as can be seen
here:

> diff -Nru a/drivers/usb/net/kaweth.c b/drivers/usb/net/kaweth.c
> - --- a/drivers/usb/net/kaweth.c      Sun Jun 20 23:28:30 2004
> +++ b/drivers/usb/net/kaweth.c        Sun Jun 20 23:28:30 2004
> @@ -592,7 +592,7 @@
>  
>       struct sk_buff *skb;
>  
> - -   if(unlikely(urb->status == -ECONNRESET || urb->status == -ECONNABORTED))
> +     if(unlikely(urb->status == -ECONNRESET || urb->status == -ECONNABORTED || 
> urb->status == -ESHUTDOWN))
>       /* we are killed - set a flag and wake the disconnect handler */
>       {
>               kaweth->end = 1;

See the extra "- " for every line that starts with a "-"?  I have to
hand edit those out, which isn't very nice at all.

So can you please stop signing patches?  Actually, can everyone stop
signing them, they provide no use to me as I don't have a valid
signature on any of the people who send me signed patches :)

thanks,

greg k-h


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to