On Wed, Jun 23, 2004 at 11:17:24PM +0200, Nemosoft Unv. wrote:
> Hello,
> 
> Attached you will find patches that will bring the PWC driver in the kernel 
> up to version 9.0.1 from 8.12 (9.0 wasn't accepted at first). Patches are 
> against 2.4.26 and 2.6.7. The main difference with 9.0 is that the 
> video_relase() routine is now hopefully in line with kernel requirements. 
> I've also added one more ioctl() call, upon request.

Thanks, looks better.  I've applied the 2.6 patch.

> Greg, did you accept the 9.0 patch for 2.4.26? I'm not sure, since the 2.4 
> kernel series do not have the video_release() requirement that 2.6 has. If 
> so, this patch will probably fail.

I'm not the USB 2.4 maintainer anymore, so I don't know if it's been
applied or not :)

> I'm also slightly in the dark on the status of the PWC in the 2.6 kernel; 
> I've seen two patches: the first was a bad one, since it would crash your 
> kernel when you unplug the cam. I've seen a second patch to reverse the 
> first one, but I don't know if that went in. Either way, you might get a 
> conflict in pwc-if.c in and about the pwc_video_release() routine; this 
> patch was generated against the clean 2.6.7 kernel source. Should you need 
> or want to fix it manually, this patch should remove the 
> pwc_video_release() in the 2.6 kernel.
> 
> Finally, could you also make sure the documentation in 
> Documentation/usb/philips.txt is updated?

As it was part of the patch, it was updated.

Oh, next time can you add the Signed-off-by: line?

thanks,

greg k-h


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to