-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Thu, 1 Jul 2004 11:06:21 -0400 (EDT) Alan Stern <[EMAIL PROTECTED]> wrote:
> > It's worth to note that a number of drivers under usb/media/ > > still implement "simple" urb removal (urb_unlink()+free_urb()) > > without the above mechanism and proper error handling. > > Although this is not a problem in most of the cases, it is likely > > that they crash the kernel on SMP machines. > > usb_unlink_urb() followed immediately by usb_free_urb() is correct, even > if the unlink is asynchronous. Reference counting of URBs guarantees that > the URB won't be deallocated until the completion handler has finished > running and the URB is idle. Hmm..What if usb_unlink_urb() actually fails and you call usb_free_urb() despite of the error? -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFA5C5hmdpdKvzmNaQRAoA0AKDBNVL4PQ8QDtU54d6lcqkThDE+jgCggp35 h6THupleAi2wowOX0vNJ4R0= =7laq -----END PGP SIGNATURE----- ------------------------------------------------------- This SF.Net email sponsored by Black Hat Briefings & Training. Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
