Greg:
As Andrew Morton has already spotted, I messed up the interpretation of
the result codes from various _trylock() routines. I didn't notice that
down_trylock() and down_read_trylock() use opposite conventions for
indicating success! This patch fixes the incorrect interpretation of
down_trylock(). That error may well be responsible for some of the
problems cropping up recently with OHCI controllers. Please apply.
Alan Stern
Signed-off-by: Alan Stern <[EMAIL PROTECTED]>
===== drivers/usb/core/usb.c 1.281 vs edited =====
--- 1.281/drivers/usb/core/usb.c Wed Jun 30 09:44:26 2004
+++ edited/drivers/usb/core/usb.c Tue Jul 6 12:00:32 2004
@@ -871,7 +871,7 @@
{
if (!down_read_trylock(&usb_all_devices_rwsem))
return 0;
- if (!down_trylock(&udev->serialize)) {
+ if (down_trylock(&udev->serialize)) {
up_read(&usb_all_devices_rwsem);
return 0;
}
-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 -
digital self defense, top technical experts, no vendor pitches,
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
