On Tue, 6 Jul 2004, Jesse Stockall wrote: > On Tue, 2004-07-06 at 11:37, Alan Stern wrote: > > Could you please try running the following experiment? On your main > > system, compile the kernel with those two patches installed, and turn on > > the USB debugging option in the configuration. Then post the dmesg output > > you get when you plug in the USB mouse and it fails to work. > > Upon further investigation there are different things happening: > > I have usb ports soldered to the board on bus 1 and ports connected via > an on-board hub on bus 2
<snip> > See attachment for bootlogs, dmesg and oops. In case attachment gets > stripped, it's @ > http://www.magma.ca/~stockall/2.6.7-mm6-usb-problems.tgz > > I can repeat with a usb storage device if required > > Jesse Your logs were very informative. They don't show why lsusb is hanging, but the cause of the oops is plain. Greg, one of the changes I made was to remove the check for urb == NULL in usb_unlink_urb(). That's causing Jesse's problem: hid_disconnect() calls usb_unlink_urb() for all the URBs it might use, whether they have been allocated or not. Should that check be put back, or should the HID driver be changed? Jesse, this patch should solve most of your problems. Alan Stern ===== drivers/usb/core/urb.c 1.44 vs edited ===== --- 1.44/drivers/usb/core/urb.c Thu Jun 24 12:44:16 2004 +++ edited/drivers/usb/core/urb.c Tue Jul 6 16:01:47 2004 @@ -447,6 +447,8 @@ */ int usb_unlink_urb(struct urb *urb) { + if (!urb) + return -EINVAL; if (!(urb->transfer_flags & URB_ASYNC_UNLINK)) { usb_kill_urb(urb); return 0; @@ -477,6 +479,8 @@ */ void usb_kill_urb(struct urb *urb) { + if (!urb) + return; if (!(urb->dev && urb->dev->bus && urb->dev->bus->op)) return; spin_lock_irq(&urb->lock); ------------------------------------------------------- This SF.Net email sponsored by Black Hat Briefings & Training. Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
