On Thu, 2004-07-08 at 18:32, David Brownell wrote:
> Hi,
>
> >>> pdev = to_pci_dev(hcd->self.controller);
> >>>
> >>>if (pci_request_region (pdev, 2, (char *) hcd_name))
> >>> return -ENOMEM;
> >>
> >>... and "}" plus probably "else { ... }". That "else"
> >>branch should probably use platform_device.resource[N];
> >>board-specific code would set up the platform device.
> >>
> >
> > So, if I get this right, the else {} branch that you propose, is in case
> > the HC is on a non-pci platform, to make sure that this driver will work
> > even if PCI is not configured? i.e to make the driver portable to other
> > implementations with the same USB controller?
>
> Exactly. An isp1160 driver will be useful primarily
> on systems without PCI ... with the exception of
> this PLX-based eval board!
>
> I've seen the same structure with the TDI243 chip:
> a PLX-based eval board with PCI, but more typical
> designs don't use PCI. (Even development systems,
> like the ARM "Versatile" board for ARM926EJ-S.)
>
> Now, you may not be in a position to make sure
> your driver works without the PLX and related
> glue ... but you're certainly in a position to
> make sure PCI-isms are limited in scope.
>
I agree 100%, but I don't understand how I can predict what to allocate
for other designs that use the isp1160. I need the locations of the
command and data ports to communicate with the isp1160, which on the
evaluation board are at PCI Base Address 2 (data port) and (PCI Base
Address 2) + 2 (command port). How can I know where to look for them on
other implementations?
Dimitris
-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 -
digital self defense, top technical experts, no vendor pitches,
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
