On Thu, Jul 08, 2004 at 12:29:50PM +0200, Olaf Hering wrote:
>  On Wed, Jul 07, Greg KH wrote:
> 
> > On Wed, Jul 07, 2004 at 02:01:04PM +0200, Olaf Hering wrote:
> > > The keyspan_pda driver locks up on a G4 and an ibook G4 when it
> > > transmits data. This happens with our sles9 kernel, which has the 2.6.6
> > > usb stack, and with current 2.6.7-mm6.
> > 
> > Can you use the keyspan.c driver instead?
> 
> I suggest to put the pointer to port instead of the pointer to the
> pointer to port to the workqueue data.
> Did that driver ever work with 2.6?
> 
> 2002/10/01 mingo      |                         (void *)(&serial->port[0]));
> 
> --- linux-2.6.7-bk20/drivers/usb/serial/keyspan_pda.c 2004-06-16 07:19:37.000000000 
> +0200
> +++ linux-2.6.7-bk20.keyspan_pda/drivers/usb/serial/keyspan_pda.c     2004-07-08 
> 12:26:37.770527150 +0200
> @@ -781,7 +781,7 @@ static int keyspan_pda_startup (struct u
>       usb_set_serial_port_data(serial->port[0], priv);
>       init_waitqueue_head(&serial->port[0]->write_wait);
>       INIT_WORK(&priv->wakeup_work, (void *)keyspan_pda_wakeup_write,
> -                     (void *)(&serial->port[0]));
> +                     (void *)(serial->port[0]));
>       INIT_WORK(&priv->unthrottle_work,
>                       (void *)keyspan_pda_request_unthrottle,
>                       (void *)(serial));


Ah, nice, I missed that when changing the port structures around.  Does
this fix the problem for you?

thanks,

greg k-h


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to