On Thu, 8 Jul 2004, Rogério Brito wrote:

> Well, the patch doesn't apply here cleanly with kernel 2.6.7. Here is what
> I have around the line where the patch you just sent me should be applied:
> 
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
>       default:                /* presumably an error */
>               /* Cause a hub reset after 10 consecutive errors */
>               dev_dbg (&hub->intf->dev, "transfer --> %d\n", urb->status);
>               if ((++hub->nerrors < 10) || hub->error)
>                       goto resubmit;
>               hub->error = urb->status;
>               /* FALL THROUGH */
>       
>       /* let khubd handle things */
>       case 0:                 /* we got data:  port status changed */
>               break;
>       }
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> 
> That's the final part of a switch statement. I don't have the for that you
> had in your patch. Do you want me to upgrade my kernel tree to yours so
> that we can stay in sync?

No, it doesn't matter.  I can't keep track of all the different versions 
floating around anyway.

> I will try anyway to put that if right after the "case 0:" clause.

Yes, please do.  The output from the printk inside the "if" statement is
all that matters.

> > Go ahead and post the debugging messages here.  Be sure to turn on the
> > usb-storage debugging option in the kernel configuration.
> 
> Ok. Should I do that after the issue above is resolved?

It's a separate question so it can be discussed independently.  Before, 
after, or during are all okay.

Alan Stern




-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to