Use list_for_each() where applicable
- for (list = ymf_devs.next; list != &ymf_devs; list = list->next) {
+ list_for_each(list, &ymf_devs) {
pure cosmetic change, defined as a preprocessor macro in:
include/linux/list.h

patch is against 2.6.7-bk20, please tell if you need against newer.


From: Domen Puncer <[EMAIL PROTECTED]>
Signed-off-by: Maximilian Attems <[EMAIL PROTECTED]>



---

 linux-2.6.7-bk20-max/drivers/usb/class/usb-midi.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff -puN drivers/usb/class/usb-midi.c~list_for_each-usb-midi 
drivers/usb/class/usb-midi.c
--- linux-2.6.7-bk20/drivers/usb/class/usb-midi.c~list_for_each-usb-midi        
2004-07-11 14:41:39.000000000 +0200
+++ linux-2.6.7-bk20-max/drivers/usb/class/usb-midi.c   2004-07-11 14:41:39.000000000 
+0200
@@ -823,9 +823,9 @@ static int usb_midi_open(struct inode *i
 
        for(;;) {
                down(&open_sem);
-               for (devs = mididevs.next; devs != &mididevs; devs = devs->next) {
+               list_for_each(devs, &mididevs) {
                        s = list_entry(devs, struct usb_midi_state, mididev);
-                       for (mdevs = s->midiDevList.next; mdevs != &s->midiDevList; 
mdevs = mdevs->next) {
+                       list_for_each(mdevs, &s->midiDevList) {
                                m = list_entry(mdevs, struct usb_mididev, list);
                                if ( !((m->dev_midi ^ minor) & ~0xf) )
                                        goto device_found;
@@ -2018,7 +2018,7 @@ static void usb_midi_disconnect(struct u
        s->usbdev = NULL;
        usb_set_intfdata (intf, NULL);
 
-       for ( list = s->midiDevList.next; list != &s->midiDevList; list = list->next ) 
{
+       list_for_each(list, &s->midiDevList) {
                m = list_entry(list, struct usb_mididev, list);
                wake_up(&(m->min.ep->wait));
                wake_up(&(m->mout.ep->wait));




-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to