On Monday 26 July 2004 03:27, you wrote: > David -- > > Here is a patch to add endpoint autoconfiguration to > the gadget serial driver. This is against 2.6.7. > > I pretty much copied gadget zero autoconfig for this. > I tested it with a NetChip 2280 development board.
Looks pretty good, thanks. > Let me know if you would like any changes or if you > want a diff against a different kernel. Should I My only two comments are: (a) submit against the latest kernel (2.6.8-rc2) which in this case has a few changes that 2.6.7 doesn't (omap_udc support may be all); (b) the highspeed test needs to be at runtime as well. Re (b) the thing is that the same driver binary can be used on hardware that can do net2280 via PCI (or potentially some other high speed controller) along with some other controller that's not highspeed-capable. And the goal is that the driver should work with any of the controller modules that are configured. > submit this and future gadget serial changes to you > or Greg or both? I may have a bit more time to review such things than Greg, but he's the one who volunteered to shepard this one into 2.6 ... I think "submit" should go to him, and linux-usb-devel. But feel free to send stuff to me for review before that. That said, you probably won't get this reply for a couple days! - Dave > Thanks, > -- Al > ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
