David:
Our work on the hub driver is well on its way to getting hopelessly
tangled. Should we try to coordinate the changes we've been sending in
independently?
With regard to your latest patch, I have some questions/comments:
There's no need to check hub->quiescing in the interrupt
handler, since usb_kill_urb() will prevent the URB from
being resubmitted.
Why do you want to use locktree() in hub_events() and
usb_reset_device()?
The comment you added to usb_disconnect() about pdev pointing
into a locked hub isn't correct when the device being
disconnected is a root hub, and the comments that follow your
change already explain what's needed.
The FIXME comments added to hub_port_disable() and hub_port_init()
are misleading, because disconnect() would run into trouble if
called from within usb_reset_device(). At one point I considered
doing the same thing but decided against it for that reason.
Rather than fretting too much about unbinding drivers that don't
support suspend(), one could improve things a lot right now by
adding suspend/resume support to the HID driver.
That's enough to start with. There were a few other smaller things
(including a misspelling: "everyting") but they can wait.
Alan Stern
-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
