On Monday 02 August 2004 15:48, Dale Farnsworth wrote:
> This 3-part patch adds support for the big-endian OHCI implementations
> found on IBM's stb04xxx and Freescale's MPC52xx processors.

Looks like it should be OK; did you re-test on x86?

I can wish such patches weren't needed, but this looks like the way
to do it if it's gonna be done.  Though I think you may have missed
some opportunities to get rid of runtime byteswaps.

- Dave


> Patch 1       Removes byteswapped OHCI constants in preparation for
>       dynamically handling endianness.
> 
> Patch 2       Adds support for big-endian OHCI controllers.
>       This is done primarily by applying the following transforms
>       when dealing with controller data:
>               ohci_readl(p)   --> ohci_read(ohci, p)
>               writel(v, p)    --> ohci_writel(ohci, v, p)
>               cpu_to_le16(v)  --> cpu_to_ohci16(ohci, v)
>               cpu_to_le16p(v) --> cpu_to_ohci16p(ohci, v)
>               cpu_to_le32(v)  --> cpu_to_ohci32(ohci, v)
>               cpu_to_le32p(v) --> cpu_to_ohci32p(ohci, v)
>               le16_to_cpu(v)  --> ohci16_to_cpu(ohci, v)
>               le16_to_cpup(v) --> ohci16_to_cpup(ohci, v)
>               le32_to_cpu(v)  --> ohci32_to_cpu(ohci, v)
>               le32_to_cpup(v) --> ohci32_to_cpup(ohci, v)
> 
>       A bit in the flags field of struct ohci_hcd, OHCI_BIG_ENDIAN,
>       enables the the transformed functions to support both
>       big-endian and little-endian controllers at runtime, if needed.
> 
> Patch 3       Adds support for ohci controllers (big-endian) on STB04xxx and 
MPC52xx


-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to