hi all
i'm digging through the USB OHCI host controller stuff, trying to
minimise the size of my ep93xx glue file. some questions i have
as i go:
- is there any reason for functions like these to exist?
ohci-omap.c:usb_hcd_omap_hcim_irq()
ohci-lh7a404.c:usb_hcd_lh7a404_hcim_irq()
why couldn't the underlying usb_hcd_irq() function be registered
directly with request_irq()?
- why is drivers/usb/core/hcd-pci.c in the core directory instead
of the host directory? it's only used by the ohci/uhci/ehci drivers,
and equivalent routines for non-pci functions are in the host
directory
- the hc_driver->start() routines for most glue files are identical
and non-specific. should that routine go into the top portion of the
drivers/usb/host/ohci-hcd.c file, with a hook to a platform specific
hc_driver->quirks() function to handle the PCI quirks detections?
- on the same topic, why does ohci_pci_start() fail to call this
chunk of code:
if (hc_reset (ohci) < 0) {
ohci_stop (hcd);
return -ENODEV;
}
when all the others seem to do this before calling hc_start()?
- there appears to be a bunch of probe/remove/suspend/resume functions
that specialize on bus type (PCI, amba, platform, omap, ...) which are
invoked from the corresponding functions for each bus type. many
of these have the same basic structure, and differ only in the
way they allocate interrupts, memory resources, etc. is it reasonable
to try and factor these out somehow?
thanks
--
----------------------------------------------------------------------
Ray L <[EMAIL PROTECTED]>
-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
