Pete Zaitcev wrote: > On Wed, 11 Aug 2004 11:42:48 -0400 (EDT) Alan Stern > <[EMAIL PROTECTED]> wrote: > >> This patch fixes the error in the UHCI driver found by Stuart Hayes. >> It adds the UHCI_PTR_QH bit into the initial entries stored in the >> hardware framelist. It's not entirely clear how the driver ever >> managed to work with these bits not set; apparently by coincidence >> the >> QH entries resembled TD entries sufficiently closely to fool the >> hardware. > >> /* Only place we don't use the frame list routines */ >> - uhci->fl->frame[i] = cpu_to_le32(uhci->skelqh[irq]->dma_handle); >> + uhci->fl->frame[i] = UHCI_PTR_QH | >> + cpu_to_le32(uhci->skelqh[irq]->dma_handle); > > What about uhci_insert_td_frame_list() and uhci_remove_td() ? > > -- Pete
My two cents worth (which is really not worth much more than that): This patch only affects the initial entries in the framelist, which are all QHs. uhci_insert_td_frame_list() and uhci_remove_td() don't need to add the UHCI_PTR_QH bit since they are putting a link to a TD (not a QH) into the frame list. These routines don't delete this bit in the original QH entry. ------------------------------------------------------- SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift. http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
