On Thu, Aug 12, 2004 at 03:13:47PM -0700, Pete Zaitcev wrote:
> On Thu, 12 Aug 2004 15:05:07 -0700
> Greg KH <[EMAIL PROTECTED]> wrote:
> 
> > diff -Nru a/drivers/block/ub.c b/drivers/block/ub.c
> > --- a/drivers/block/ub.c    2004-08-12 15:02:55 -07:00
> > +++ b/drivers/block/ub.c    2004-08-12 15:02:55 -07:00
> > @@ -1842,6 +1842,7 @@
> >     disk->first_minor = sc->id * UB_MINORS_PER_MAJOR;
> >     disk->fops = &ub_bd_fops;
> >     disk->private_data = sc;
> > +   disk->driverfs_dev = &intf->dev;
> >  
> >     rc = -ENOMEM;
> >     if ((q = blk_init_queue(ub_bd_rq_fn, &sc->lock)) == NULL)
> 
> Hmm. Are you sure there's no need to do some sort of dev_get here?
> Silly question, but...

That happens for us in the disk_sysfs_symlinks() function in the block
core.

Or it sure looks that way to me :)

thanks,

greg k-h


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to