ChangeSet 1.1807.48.7, 2004/07/30 16:35:24-07:00, [EMAIL PROTECTED] [PATCH] USB: ftdi_sio doesn't re-assert DTR modem control line
I've dredged up another old ftdi_sio patch that I never Cc'd to you the first time. Please see Nathan's description below. It applies okay against your usb-2.6 tree, with or without the patch I posted yesterday to support the FT2232C chip and neither patch invalidates the other in any way. On 25/06/2004 21:56, Croy, Nathan wrote: > SUMMARY > ======= > ftdi_sio never reasserts modem control lines once the baud has been set to > B0. > > DESCRIPTION > =========== > Setting the baud to B0 (hangup) drops DTR. When the baud is raised again, > DTR is not raised. This can cause a modem to ignore any commands sent to it > until the device is closed and reopened. This renders minicom (and other > software) useless, unless you instruct the modem to ignore DTR. > > The following patch is intended to make ftdi_sio act like other serial > devices I have used (i.e. the standard serial ports (/dev/ttyS*) and > stallion ports (/dev/ttyE*)). Upon setting the baud to something other than > B0, it ensures the modem control lines are set back to the way they were > when the port was opened. > > Thanks to Ian Abbott for confirming my suspicions: > http://sourceforge.net/mailarchive/forum.php?thread_id=4984710&forum_id=12120 Nathan's email suffered from a line-folding bug (blame M$, probably!), so his patch came out corrupted. I'm reposting an uncorrupted version. Signed off by: Ian Abbott <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> drivers/usb/serial/ftdi_sio.c | 7 +++++++ 1 files changed, 7 insertions(+) diff -Nru a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c --- a/drivers/usb/serial/ftdi_sio.c 2004-08-23 13:21:42 -07:00 +++ b/drivers/usb/serial/ftdi_sio.c 2004-08-23 13:21:42 -07:00 @@ -1903,6 +1903,13 @@ if (change_speed(port)) { err("%s urb failed to set baurdrate", __FUNCTION__); } + /* Ensure RTS and DTR are raised */ + else if (set_dtr(port, HIGH) < 0){ + err("%s Error from DTR HIGH urb", __FUNCTION__); + } + else if (set_rts(port, HIGH) < 0){ + err("%s Error from RTS HIGH urb", __FUNCTION__); + } } /* Set flow control */ ------------------------------------------------------- SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift. http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
