When this question arose many years ago, SuSE simply removed the message,
but I was very new to the code and was too conservative, so I count-limited
the message. Later, someone rate-limited it upstream, but it is too annoying
still. The right thing is to kill the message.
I was in a situation where it kinda gave a hint that something was wrong,
but I evaluate its usefulness against the annoyance and annoyance wins.
-- Pete
diff -urp -X dontdiff linux-2.4.28-pre1/drivers/usb/host/usb-uhci.c
linux-2.4.28-pre1-usb/drivers/usb/host/usb-uhci.c
--- linux-2.4.28-pre1/drivers/usb/host/usb-uhci.c 2004-02-26 14:09:58.000000000
-0800
+++ linux-2.4.28-pre1-usb/drivers/usb/host/usb-uhci.c 2004-08-24 12:41:07.000000000
-0700
@@ -2746,13 +2746,8 @@ _static void uhci_interrupt (int irq, vo
dbg("interrupt");
if (status != 1) {
- // Avoid too much error messages at a time
- if (time_after(jiffies, s->last_error_time + ERROR_SUPPRESSION_TIME)) {
- warn("interrupt, status %x, frame# %i", status,
- UHCI_GET_CURRENT_FRAME(s));
- s->last_error_time = jiffies;
- }
-
+ dbg("status %x, frame# %i", status, UHCI_GET_CURRENT_FRAME(s));
+
// remove host controller halted state
if ((status&0x20) && (s->running)) {
err("Host controller halted, trying to restart.");
diff -urp -X dontdiff linux-2.4.28-pre1/drivers/usb/host/usb-uhci.h
linux-2.4.28-pre1-usb/drivers/usb/host/usb-uhci.h
--- linux-2.4.28-pre1/drivers/usb/host/usb-uhci.h 2003-06-13 07:51:36.000000000
-0700
+++ linux-2.4.28-pre1-usb/drivers/usb/host/usb-uhci.h 2004-08-24 12:41:07.000000000
-0700
@@ -218,7 +218,6 @@ typedef struct uhci {
int timeout_urbs;
struct pci_dev *uhci_pci;
struct pci_pool *desc_pool;
- long last_error_time; // last error output in uhci_interrupt()
} uhci_t, *puhci_t;
-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
