On Fri, Aug 27, 2004 at 10:48:44PM -0400, Alan Stern wrote: > On Fri, 27 Aug 2004, Oliver Neukum wrote: > > > > > > @@ -668,7 +668,7 @@ > > > > > INTBUFFERSIZE, > > > > > int_callback, > > > > > kaweth, > > > > > - HZ/4); > > > > > + 8); > > > > > kaweth->irq_urb->transfer_dma = kaweth->intbufferhandle; > > > > > kaweth->irq_urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP; > > > > That field can't handle such a big number, so I just guesed as to what > > > you really ment it to be. Have a better suggestion? > > > > Yes. Revert it. Sparse here has overreached the limit of its usefullness. > > The device is always full speed, never high speed. The shift won't be used. > > The value is what the vendor recommends. > > I see this is part of a call to usb_fill_int_urb(). Since the device > always runs at full speed, the value should be a time interval given in > frames, i.e., milliseconds. If you intend the URB to fire every 250ms, > then the value should be 250 -- not HZ/4, which can vary considerably > among platforms. Alternatively, you could copy the value from the > endpoint's descriptor.
Alan is correct. This value changed when we changed HZ to be 1000 from 100. It should not change. It will be different depending on the arch the driver is running on (different archs have different HZ these days.) And what about the "change HZ as a config option" patch that's always floating around? :) Care to send me a patch that puts this value at the correct value? thanks, greg k-h ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
