Am Dienstag, 31. August 2004 17:41 schrieb Alan Stern: > On Tue, 31 Aug 2004, Oliver Neukum wrote: > > Alan Stern > > > > > > @@ -822,9 +822,8 @@ > > > > usb_set_intfdata(intf, NULL); > > > > + usb_kill_urb(desc->urb); > > scsi_remove_host(desc->host); > > - usb_unlink_urb(desc->urb); > > - scsi_host_put(desc->host); > > > > usb_free_urb(desc->urb); > > kfree(desc); > > I think you still need the scsi_host_put(), to account for the fact that > scsi_host_alloc() sets the refcount to 1 initially.
Right you are. Greg, please also apply this one. Signed-Off-By: Oliver Neukum <[EMAIL PROTECTED]> You can import this changeset into BK by piping this whole message to: '| bk receive [path to repository]' or apply the patch as usual. =================================================================== [EMAIL PROTECTED], 2004-08-31 18:54:12+02:00, [EMAIL PROTECTED] - reference counting fix microtek.c | 1 + 1 files changed, 1 insertion(+) diff -Nru a/drivers/usb/image/microtek.c b/drivers/usb/image/microtek.c --- a/drivers/usb/image/microtek.c Tue Aug 31 19:10:57 2004 +++ b/drivers/usb/image/microtek.c Tue Aug 31 19:10:57 2004 @@ -825,6 +825,7 @@ usb_kill_urb(desc->urb); scsi_remove_host(desc->host); + scsi_host_put(desc->host); usb_free_urb(desc->urb); kfree(desc); } =================================================================== This BitKeeper patch contains the following changesets: 1.1823 ## Wrapped with gzip_uu ## M'XL( "&Q-$$ \V436_4,!"&S^M?8:D74)5DQG8^T5:%@@"!U-5"SU5P9C=1 MD[BRG5*D_'B2K=1V$=KR=<#VQ>/Q*[\SCWS$+QS98F':YH8L.^+OC//3EGK3 M4UB;CMJF'VY#8[?3X=J8Z3":PY%IVT9$GRV1B^8<)Q(VI:Q*KVL^:;EB@:&\ MC_AOUU0LUF_>7GQ\N69LN>1G==EOZ1-YOEPR;^Q-V5;NM/1U:_K0V[)W'?DR MU*8;[U-' 2"F&6,J(4Y&3$"EH\8*L51(%0B5)8K=N3G]F8M]+069!,[EMAIL PROTECTED] M&6/&7G,,,[EMAIL PROTECTED]@BR1RS(I8%2B.010 _( V/T8> 'O%_ZV;,Z9YP"UMR%*O MB6LS]+[IMWS3W+(/?'HW)&[EMAIL PROTECTED]@)T\\N[*S<1<-[DO4-=H:3U>A M?N1! :9C(D'*L41(22NA<I&I2FX.56U/N.G*+?T@/S<),8DE)*-(4,8[? [= M>IJHOS%S$*]?,3,3EZIL%#+.Y8XXA?N\R0*2_Y6WNQ:<\\!^W:V)G]7!;OP! MC^\SD7)D"Z==<UE/7]+E]>"?5>1T<#)OG[]X^&MT3?K*#=TRQCB-,\C9=_9_ &G%_5! ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel