On 13/09/2004 13:48, Jan Capek wrote:
That race condition is exactly what I was talking about. Since it's bound to be pretty rare, there's probably no harm in displaying the error message. But it also wouldn't hurt to check for result != -EPERM. It's your choice.
Alan Stern
I think, it's better to leave the error message in there as it is.
It's only at debug level anyway, so shouldn't be too annoying.
The attached patch covers the fixes in ftdi_sio.c and usb-serial.c.
It might be better to resubmit it as two patches.
Could anyone (Ian/Alan?) put the 'signed-off-by:' stamp on it after looking at it, so that it can be applied by Greg?
You're meant to sign them off yourself, first!
FWIW, the ftdi_sio change looks okay by me, assuming you've tested it. (I haven't tested it myself yet and don't know much about usb_kill_urb, but if that's the way to go, then so be it!)
-- -=( Ian Abbott @ MEV Ltd. E-mail: <[EMAIL PROTECTED]> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM. Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
