I sent this to the usb-storage list for testing, but I thought I might reach a slightly wider audience here.

The attached patch removes the Genesys HD entries from unusual_devs.h. Two of the entries *only* purpose was to request 36 bytes instead of 255, but since the kernel does that be default now anyway, this isn't needed.

The other entry also has MODE_XLATE, but as far as I know, this isn't used in the 2.6 kernel for anything.

Therefore, I believe these entries are no longer needed. On top of that, one of the entries is causing issues for some users (as reported on usb-storage).

If anyone who has one of the effected devices could test this -- I'll send it more formally to Greg in a week or so if I don't see any complaints.

Thanks.
--
Phil Dibowitz                             [EMAIL PROTECTED]
Freeware and Technical Pages              Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"They that can give up essential liberty to obtain a little temporary
safety deserve neither liberty nor safety."
 - Benjamin Franklin, 1759

--- drivers/usb/storage/unusual_devs.h.orig	2004-09-09 19:23:17.000000000 -0700
+++ drivers/usb/storage/unusual_devs.h	2004-09-22 15:43:14.000000000 -0700
@@ -439,36 +439,6 @@
 		US_SC_DEVICE, US_PR_DEVICE, NULL,
 		US_FL_FIX_INQUIRY ),
 
-/* Reported by Carlos Villegas <[EMAIL PROTECTED]>
- * This device needs an INQUIRY of exactly 36-bytes to function.
- * That is the only reason this entry is needed.
- */
-UNUSUAL_DEV(  0x05e3, 0x0700, 0x0000, 0xffff,
-		"Genesys Logic",
-		"USB to IDE Card Reader",
-		US_SC_DEVICE, US_PR_DEVICE, NULL,
-		US_FL_FIX_INQUIRY ),
-
-/* Submitted Alexander Oltu <[EMAIL PROTECTED]> */
-UNUSUAL_DEV(  0x05e3, 0x0701, 0x0000, 0xffff, 
-		"Genesys Logic", 
-		"USB to IDE Optical",
-		US_SC_DEVICE, US_PR_DEVICE, NULL,
-		US_FL_MODE_XLATE ), 
-
-/* Reported by Peter Marks <[EMAIL PROTECTED]>
- * Like the SIIG unit above, this unit needs an INQUIRY to ask for exactly
- * 36 bytes of data.  No more, no less. That is the only reason this entry
- * is needed.
- *
- * ST818 slim drives (rev 0.02) don't need special care.
-*/
-UNUSUAL_DEV(  0x05e3, 0x0702, 0x0000, 0xffff,
-		"Genesys Logic",
-		"USB to IDE Disk",
-		US_SC_DEVICE, US_PR_DEVICE, NULL,
-		US_FL_FIX_INQUIRY ),
-
 /* Reported by Hanno Boeck <[EMAIL PROTECTED]>
  * Taken from the Lycoris Kernel */
 UNUSUAL_DEV(  0x0636, 0x0003, 0x0000, 0x9999,

Attachment: signature.asc
Description: OpenPGP digital signature



Reply via email to