Hi Ian,

> The patches are missing the definition of struct ohci_chip_info. I can't
> do hw reset or stop/start the clock with my h/w so I just commented them
> out for now.
> 
I defined it like this:
struct ohci_chip_info {
        void (*hw_reset) (int devid, int set);
        void (*clock_enable) (int devid);
        void (*clock_disable) (int devid);
};
Since this needs to be shared with the platform specific code it
should should probably be defined in include/asm/arch/ rather than in
some usb include file. This also gives the opportunity to pass
parameters that differ between platforms to the driver.

> The attached usb-ohci-isp1362-chipid makes the code in chip_probe aware
> of the 116x HCCHIPID value by looking for the correct value based on
> CHIP_TYPE. Long term it might be good to select CHIP_TYPE based on the
> magic value to save hard coding it. 
> 
I'm missing this attachment.
There were only three attachments:
usb-ohci-emu-debug
usb-ohci-emu-kconfig
usb-ohci-emu-rejects



Lothar Wassmann


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to