UHCI_NUMFRAMES will never change, it is a standard.
Ok, then
I'll recheck with gcc 3.4 of fc3. I guess it'll stay the same. Anyhow this is interrupt level, time critical code so I think the patch is the right way to go.
I just checked this code:
unsigned int test(void)
{
return 10;
}int main(int argc, char *argv[])
{
unsigned int a;a = test();
printf("%d\n", a % 8);return 0; }
The "test" function is just to not let the compiler optimize away everything because it knows the value of "a". (although, it it was a little smarter it could figure out even that :)
With gcc 3.3.2 it produces this output:
.type main, @function
main:
pushl %ebp
movl %esp, %ebp
pushl %ecx
pushl %ecx
andl $-16, %esp
call test
andl $7, %eax
^^^^^^^^^^^^^^^^
pushl %edx
pushl %edx
pushl %eax
pushl $.LC0
call printf
xorl %eax, %eax
leave
retSo it works as expected...
Anyway, I really have no strong feelings about this, and I'm in no way responsible for accepting the patch, so those were just my 2 cents
-- Paulo Marques - www.grupopie.com
All that is necessary for the triumph of evil is that good men do nothing. Edmund Burke (1729 - 1797)
------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
