For those interested, here are the changes: -call to set_ldisc in cypress_set_termios removed
-kept TCSETS/TCGETS in cypress_ioctl as they were indeed necessary -set up proper flagging of parity errors on packets sent to tty layer -added missing return to cypress_interrupt_write_callback so work is no longer scheduled when urb->status is flagged -replaced throttling code with model from ftdi_sio/whiteheat drivers, no longer calling usb_unlink_urb from cypress_throttle. -replaced usb_unlink_urb in cypress_close with usb_kill_urb -added missing calls to free up buffer allocated for write urb on error event in cypress_write -more locking tweaks and misc. fixes I tested the driver with 2.6.9-rc3-bk3 (the first occurance of semaphore locking in tty_ioctl) with success on a dual p2 smp machine. No problems encountered when running the suggested test 'cat /dev/zero > /dev/tts/USB0' (2 hour run time test). I feel the urb/buffer allocation for cypress_write is fine. As long as the urb and buffer are properly free'd upon occurance of errors and callback return it should not be much of a problem. When I first submitted the driver for review a long while back, cypress_write used a pool of write urbs. Greg suggested that this was not necessary, and so I removed that particular code. I do understand where you were going with that suggestion though and I might submitt some patches adding back in a similiar method at a later time if someone doesn't beat me to the punch. The patch series will be resubmitted shortly after this message. ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
