Greg, All,

This is the patch for it.

Kind regards,

Philippe Bertin.



Greg KH wrote:
On Sat, Oct 02, 2004 at 03:20:46PM +0200, Philippe Bertin wrote:
  
'Llo All, Greg,

To my modest kernel-newby reader opinion, statement

id = usb_drv->id_table;

on line 535 of usb.c version 2.6.8.1 is superfluous, as it is re- set 
the statement after (line 537). Not that I know that much of the kernel 
itself, but reading/writing C is one of my daily programmer activities. 
And there are (unless I'm overlooking something) no side-effects to this 
statement, apart from uselessly spending time when not optimized-out by 
the compiler.

How small this improvement might be, and given the number of computers 
running Linux, and the usb- devices around using this routine, I think I 
saved human mankind some seconds :)
    

Care to send a patch?

thanks,

greg k-h


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel



  
--- linux-2.6.8/drivers/usb/core/usb.c  2004-08-14 07:36:58.000000000 +0200
+++ linux-2.6.8/drivers/usb/core/usb_patched.c  2004-10-06 21:46:34.000000000 +0200
@@ -530,9 +530,7 @@
                return 0;
 
        intf = to_usb_interface(dev);
-
        usb_drv = to_usb_driver(drv);
-       id = usb_drv->id_table;
        
        id = usb_match_id (intf, usb_drv->id_table);
        if (id)

Reply via email to