Hi Michael, Michael Moedt writes: > I've got a couple comments and questions: > > 1. The ohci-isp1362.tgz files won't work without the ohci-emu patch. > Should these be bundled together? > (note: ohci-regs.h is added by both) > Yes, I hope I find some time to do this. But for now I'm too busy with different stuff. :(
> 2. I downloaded the latest version of these drivers from > http://www.karo-electronics.de/132.0.html. Can you add some sort of > timestamp to it? (e.g. ochi-isp1362_1007.tgz) It would be nice to > know when it has last been updated. > Sure. > 3. In drivers/usb/Kconfig: > config USB > tristate "Support for Host-side USB" > depends on PCI || SA1111 || ARCH_OMAP1510 || ARCH_OMAP1610 || > ARCH_LH7A404 || ARCH_KARO || MACH_OSCAR > > It would be nice to fix this. I wouldn't want to have to patch this > file anytime someone has a machine that uses a USB controller. Have > any ideas? (maybe take out all dependencies?) > I think it wouldn't hurt too much to remove the dependencies. > @@ -533,18 +539,15 @@ > wIndex--; > switch (wValue) { > case USB_PORT_FEAT_SUSPEND: > - writel (RH_PS_PSS, > - &ohci->regs->roothub.portstatus [wIndex]); > + ohci_write_roothub_portstatus(ohci, wIndex, RH_PS_PSS); > break; [...] > This is what the code looks like for 2.6.9-rc2: > > > switch (wValue) { > case USB_PORT_FEAT_ENABLE: > temp = RH_PS_CCS; > break; > case USB_PORT_FEAT_C_ENABLE: > temp = RH_PS_PESC; > break; [...] > ohci_write_roothub_portstatus(ohci, wIndex, temp); > //roothub_portstatus(ohci, wIndex); > The purpose of the patch is to convert all ohci register accesses from readl/writel() instructions to using macros that provide the possibility to emulate registers that are not supported by the hardware. The 2.6.8 code directly wrote the hardware registers for every 'case' of the switch() statement. The 2.6.9 only sets up a variable according to the switch() value and uses only one write to the hardware register after the switch which is effectively equivalent. Lothar Wassmann ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
