ChangeSet 1.1832.55.41, 2004/09/09 10:04:05-07:00, [EMAIL PROTECTED]
[PATCH] USB: fix up usblp usb_unlink_urb() warning
On Thursday 09 September 2004 08:38, Greg KH wrote:
> On Thu, Sep 09, 2004 at 01:07:05AM -0400, Gene Heskett wrote:
> > Greetings;
> >
> > I just had to reboot back to -mm2 after playing with some printer configs
> > in cups, although the test pages worked, so I'm not sure what this all
> > about, from var log/messages:
> >
> > Sep 8 23:13:42 coyote cups: cupsd -HUP succeeded
> > Sep 8 23:13:43 coyote kernel: usb_unlink_urb() is deprecated for
> > synchronous unlinks. Use usb_kill_urb() Sep 8 23:13:43 coyote kernel:
> > Badness in usb_unlink_urb at drivers/usb/core/urb.c:456 Sep 8 23:13:44
> > coyote kernel: [<c01048ce>] dump_stack+0x1e/0x20 Sep 8 23:13:44 coyote
> > kernel: [<c0295f35>] usb_unlink_urb+0x85/0xa0 Sep 8 23:13:44 coyote
> > kernel: [<c02a7447>] usblp_unlink_urbs+0x17/0x40 Sep 8 23:13:44 coyote
> > kernel: [<c02a74a8>] usblp_release+0x38/0x60 Sep 8 23:13:44 coyote
> > kernel: [<c01501ea>] __fput+0x12a/0x140
> > Sep 8 23:13:44 coyote kernel: [<c014e8e7>] filp_close+0x57/0x80
> > Sep 8 23:13:44 coyote kernel: [<c014e971>] sys_close+0x61/0x90
> > Sep 8 23:13:44 coyote kernel: [<c010425d>] sysenter_past_esp+0x52/0x71
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
drivers/usb/class/usblp.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -Nru a/drivers/usb/class/usblp.c b/drivers/usb/class/usblp.c
--- a/drivers/usb/class/usblp.c 2004-10-19 08:16:55 -07:00
+++ b/drivers/usb/class/usblp.c 2004-10-19 08:16:55 -07:00
@@ -410,9 +410,9 @@
static void usblp_unlink_urbs(struct usblp *usblp)
{
- usb_unlink_urb(usblp->writeurb);
+ usb_kill_urb(usblp->writeurb);
if (usblp->bidir)
- usb_unlink_urb(usblp->readurb);
+ usb_kill_urb(usblp->readurb);
}
static int usblp_release(struct inode *inode, struct file *file)
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
