ChangeSet 1.1939.1.60, 2004/09/29 12:51:18-07:00, [EMAIL PROTECTED]
[PATCH] USB: remove _some_ calls to usb_unlink_urb in misc/auerswald.c
here's a more controversial one. Firstly, auerchain_unlink_urb:1180
is a wrapper for usb_unlink_urb so i don't think we should change
that. Secondly, auerswald_int_release returns an int which is the
error code returned by usb_unlink_urb. usb_kill_urb is a void,
however, so I've removed the error checking. For the sake of
debugging, the dbg-line announcing the name of the function is
probably enough.
Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
drivers/usb/misc/auerswald.c | 14 ++++----------
1 files changed, 4 insertions(+), 10 deletions(-)
diff -Nru a/drivers/usb/misc/auerswald.c b/drivers/usb/misc/auerswald.c
--- a/drivers/usb/misc/auerswald.c 2004-10-19 08:08:16 -07:00
+++ b/drivers/usb/misc/auerswald.c 2004-10-19 08:08:16 -07:00
@@ -516,7 +516,7 @@
urbp = acep->urbp;
urbp->transfer_flags &= ~URB_ASYNC_UNLINK;
dbg ("unlink active urb");
- usb_unlink_urb (urbp);
+ usb_kill_urb (urbp);
}
}
@@ -1171,22 +1171,16 @@
endpoint. This function returns 0 if successful or an error code.
NOTE: no mutex please!
*/
-static int auerswald_int_release (pauerswald_t cp)
+static void auerswald_int_release (pauerswald_t cp)
{
- int ret = 0;
dbg ("auerswald_int_release");
/* stop the int endpoint */
- if (cp->inturbp) {
- ret = usb_unlink_urb (cp->inturbp);
- if (ret)
- dbg ("nonzero int unlink result received: %d", ret);
- }
+ if (cp->inturbp)
+ usb_kill_urb (cp->inturbp);
/* deallocate memory */
auerswald_int_free (cp);
-
- return ret;
}
/* --------------------------------------------------------------------- */
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
