On Tue, Oct 19, 2004 at 01:47:30PM -0400, Pete Zaitcev wrote:
> > From: Greg KH <[EMAIL PROTECTED]>
>
> > ChangeSet 1.2133, 2004/10/15 16:12:52-07:00, [EMAIL PROTECTED]
> > USB: add endian markups to the ub driver.
>
> > +++ b/drivers/block/ub.c 2004-10-19 08:06:11 -07:00
> > @@ -1692,8 +1692,8 @@
> > }
> >
> > /* sd.c special-cases sector size of 0 to mean 512. Needed? Safe? */
> > - nsec = be32_to_cpu(*(u32 *)p) + 1;
> > - bsize = be32_to_cpu(*(u32 *)(p + 4));
> > + nsec = be32_to_cpu(*(__be32 *)p) + 1;
> > + bsize = be32_to_cpu(*(__be32 *)(p + 4));
> > switch (bsize) {
> > case 512: shift = 0; break;
> > case 1024: shift = 1; break;
>
> I don't think this can be right. I only want it off by 1 sector, not
> 1 kilobyte. Are you sure about this patch?
I only changed the u32 to __be32, nothing else. This fixes the sparse
endian warnings that the driver was spitting out. It should not have
changed any logic, right?
thanks,
greg k-h
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
