On Wed, Oct 20, 2004 at 12:23:06PM -0400, Alan Stern wrote: > On Wed, 20 Oct 2004, Greg KH wrote: > > > On Wed, Oct 20, 2004 at 11:29:15AM -0400, Alan Stern wrote: > > > Greg: > > > > > > Although some of the data types declared in include/linux/usb_ch9.h have > > > been converted to the __le16 usage, not all of them have. This patch > > > finishes the job. I also took the opportunity to improve the formatting > > > by converting sequences of spaces to tabs. > > > > Did you run sparse (with -Wbitwise) after doing this? I tried it a > > while ago, and just changing the types of the structures did not solve > > the issues. From what I remember, we read in the structures in __le > > form, but then convert the structures in-place so that the drivers and > > rest of the core don't have to always be converting them all the time. > > Ooh, you're right. > > One way of handling this is to declare two sets of structures: one for the > host-order converted data used internally by the kernel and the other for > the little-endian data as sent to/from devices. Do you think it's > worthwhile going to the trouble?
I really don't think it's worthwhile. But feel free to play around with it and see if it helps. thanks, greg k-h ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
