Hi,
usb_kill_urb causes -EPERM to be returned under noprmal conditions,
which should not be reported as errors.
Please apply.
Regards
Oliver
Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]>
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
===================================================================
[EMAIL PROTECTED], 2004-10-21 23:05:52+02:00, [EMAIL PROTECTED]
- do not report EPERM from usb_kill_urb as an error
kaweth.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff -Nru a/drivers/usb/net/kaweth.c b/drivers/usb/net/kaweth.c
--- a/drivers/usb/net/kaweth.c Thu Oct 21 23:06:46 2004
+++ b/drivers/usb/net/kaweth.c Thu Oct 21 23:06:46 2004
@@ -493,7 +493,7 @@
kaweth->suspend_lowmem_ctrl = 0;
}
- if (status)
+ if (unlikely(status != 0 && status != -EPERM))
err ("can't resubmit intr, %s-%s, status %d",
kaweth->dev->bus->bus_name,
kaweth->dev->devpath, status);
@@ -567,7 +567,8 @@
kaweth->suspend_lowmem_rx = 1;
schedule_delayed_work(&kaweth->lowmem_work, HZ/4);
}
- kaweth_err("resubmitting rx_urb %d failed", result);
+ if (result != -EPERM)
+ kaweth_err("resubmitting rx_urb %d failed", result);
} else {
kaweth->suspend_lowmem_rx = 0;
}
@@ -1151,7 +1152,9 @@
return;
}
+ spin_lock(&kaweth->device_lock);
kaweth->removed = 1;
+ spin_unlock(&kaweth->device_lock);
usb_kill_urb(kaweth->irq_urb);
usb_kill_urb(kaweth->rx_urb);
usb_kill_urb(kaweth->tx_urb);
===================================================================
This BitKeeper patch contains the following changesets:
1.2038
## Wrapped with gzip_uu ##
M'XL( .8D>$$ \U4:VO;,!3]'/V*NY:5E,[VE2S;L4=*M[9L91L+V?HY*+;2
[EMAIL PROTECTED],[EMAIL PROTECTED]<?WW'O0(5P;J9.!*O);J<DAO%?&-EM9
MJE*Z2[6615Y6]Z[2-\WA5*GFT&O#GBJ*G'E?M93&NU-ZQ4+2(";"IDMHJ$PR
MH*Z_C=B'C4P&T\MWUQ_?3 D9C^%\*<H;^45:&(^)5?I6%)DY$W99J-*U6I1F
M+:UP4[6NM]":(;+F#6CD8Q#6-$0>U2G-*!6<[EMAIL PROTECTED]'X6<]&+.GA*QR\4I,LK0
MCQFO&6,8DPN@;A,8 7*/HL<H,#_!( G8";($$?9PPPD%!\E;^+MJSDD*#F0*
M2F5!RXW2%BXGE]-/L-!J#969SU9Y4<PJ/0=A0)[EMAIL PROTECTED]::?(!6THA,'EM-G-]\
M"$&!Y!0V[1"?EI/IMB'&:^KP5N).VJ6;;I4QI(A8TU',_'HN8\$Y+N8\RU+D
M;%\O=VA+:7>H^[%1Y!C5 488=H9Z+J/UUS^I?Z_/?EY_XS(6U[SYC=_9+HQV
M3<<3C'[%= $X[#\R73^0S^#HN^YK3#1Y=C9_8,@+'H= R56_#/(%#*NRR%>R
M>!@:*VQEX,48$(Z.X''K=+4?'Y.+(,(VNUT8&73I6IJJL#_ [EMAIL PROTECTED]>
MM(#Y.K<V+V] WW>B7V:P$'DALX-7T!,<OR97E 9^6Y79Y.6L4.EJ>-03.:>9
GO,U3V06_([EMAIL PROTECTED]>HNE2IBM3K<?!?$'C-./D&[\UGF2_!0
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
