ChangeSet 1.2000.6.20, 2004/10/20 16:36:50-07:00, [EMAIL PROTECTED]

[PATCH] UHCI: No bandwidth reclamation during enumeration

A few devices prefer not to have full-speed bandwidth reclamation turned
on while they are being enumerated.  In particular this seems to be true
for the USB Bluetooth adapters built in to some laptop models (used for
remote keyboards).  This patch alters the UHCI driver so that control URBs
for devices still in the USB_STATE_DEFAULT state will be placed on the
low-speed queue rather than the full-speed queue.  Since the low-speed
queue isn't subject to bandwidth reclamation the devices will work
properly.  The negative impact on other devices is minimal; the process of
device initialization will be slowed down by a few milliseconds.



Signed-off-by: Alan Stern <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>


 drivers/usb/host/uhci-hcd.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)


diff -Nru a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c
--- a/drivers/usb/host/uhci-hcd.c       2004-10-22 16:13:57 -07:00
+++ b/drivers/usb/host/uhci-hcd.c       2004-10-22 16:13:57 -07:00
@@ -765,8 +765,12 @@
 
        uhci_insert_tds_in_qh(qh, urb, UHCI_PTR_BREADTH);
 
-       /* Low-speed transfers get a different queue, and won't hog the bus */
-       if (urb->dev->speed == USB_SPEED_LOW)
+       /* Low-speed transfers get a different queue, and won't hog the bus.
+        * Also, some devices enumerate better without FSBR; the easiest way
+        * to do that is to put URBs on the low-speed queue while the device
+        * is in the DEFAULT state. */
+       if (urb->dev->speed == USB_SPEED_LOW ||
+                       urb->dev->state == USB_STATE_DEFAULT)
                skelqh = uhci->skel_ls_control_qh;
        else {
                skelqh = uhci->skel_fs_control_qh;



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to