On Wednesday 27 October 2004 02:54, Ben Dooks wrote: > On Tue, Oct 19, 2004 at 03:33:52PM -0700, David Brownell wrote: > > On Tuesday 19 October 2004 2:14 pm, Ben Dooks wrote: > > > > If you're up for it, I'd rather see a generic hook for > > > > turning port N power on/off ... just hang a method in > > > > the "struct ohci_hcd", and when it's there ohci-hub.c > > > > would call it. It's not just S3C2410 boards needing > > > > custom power switching (and overcurrent) handlers! > > > > > > ... > > I was giving this some more thought, and would it be better to > do an new file with an helper functions to allow an ohci > implementation to override hc_driver.hub_status_data and > hc_driver.hub_control?
I'm not sure I follow. Why a new file? If that's how you want to plug things in, it's easy enough ... ohci-s3c2410.c (or whatever!) provides the hc_driver structure, so it can just fill in versions of those methods that switch on the request, delegating all but a few to the generic code. > I'd be happy with this way, as it would be less intrusive > into the usb hub code, and (iicc) should be as good as > changing the hub code itself. It was also the way you were already doing things, ISTR! No problem. - Dave ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
