On Fri, 29 Oct 2004, David Brownell wrote: > On Thursday 28 October 2004 14:08, Alan Stern wrote: > > On Thu, 28 Oct 2004, David Brownell wrote: > > > > I intend to split it up into multiple patches, but the split won't be on > > functional grounds. It will just be based on the source arrangement > > (like: everything in usb/core, everything in usb/host, and everything in > > usb/gadget). > > That can work. What I was getting at was that even > the usbcore bits seemed to involve several functional > changes ... and for something like this, it's a lot > easier for someone (in particular me!) to see what's > going on if the changes get factored a bit better. > (Sometimes good delta comments solve that issue...)
I can't think of any good way to factor that patch (i.e., the one to consolidate all the operations required is setting up and tearing down a usb_hcd). It will, however, be separate from the patch that fixes up the memory lifecycle. > > For now I'll leave the struct usb_hcd as the first member of the larger > > driver-specific structures. Changing over to make the the driver-specific > > part an extra add-on to the usb_hcd part (à la struct Scsi_Host) will > > involve a fair number of changes to the HC drivers themselves. > > Having just seen your patch to change the API by requiring > the use of type punning, I wonder whether we'd even really > need to adopt the alloc_etherdev() model here. It's not like > there'll ever be as many HCDs as there are Ethernet drivers, > and we don't really have a "legacy driver" issue any more. It'll be cleaner, and (without having looked to see what's really involved) I suspect that not too much work will be needed. Alan Stern ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
