On Monday 08 November 2004 13:33, Alan Stern wrote: > On Mon, 8 Nov 2004, David Brownell wrote: > > > > Most of the areas of conflict are places where I converted, for example, > > > ohci->hcd into ohci_to_hcd(ohci). > > > > I guess I'd need to see that patch. I was kind of hoping > > to hold off on cleanups in favor of bugfixes for a while, > > at least inside usbcore. ... > > Attached are just two of the patches: one for the core and one for the > UHCI driver. The OHCI patch is very similar, just with lots more places > to change, so it's not attached here.
The SL-811 code will need updates too (or it will, once there's one that compiles and runs), also EHCI ... plus there's another OHCI patch pending, for those big-endian PPC variants. That doesn't look too heinous, though I don't see where you hand the HCDs their private data; that's what I'd expect in hcd->self.hcpriv, but that's just "hcd" which clearly is already known. If you're using the alloc_etherdev() model, the hardware-specific struct doesn't contain the generic one. I'm still not planning to start on my part of that (analagous changes for usb_device) till 2.6.11 gets closer ... maybe we can get rid of "usb_operations" at that time, too. > The changes have the same form: > replace ohci->hcd with hcd (if it's available) or with ohci_to_hcd(ohci). > If you want to see the complete patch I will send it separately (it's a > bit long). > > There are three partially-related but still interesting aspects to the > core patch: > > hcd->description is removed since we can simply use > hcd->driver->description instead. Code Evolution In Action! > hcd->state is explicitly initialized to USB_STATE_HALT when the > hcd structure is created. As opposed to implicitly as part of bzeroing the memory. > usb_bus->class_device is initialized when the bus is, and > then added (not registered) when the bus is registered. No prob. - Dave > Alan Stern > ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
