On Tuesday 16 November 2004 12:44, Alan Stern wrote: > On Mon, 15 Nov 2004, David Brownell wrote: > > > Now that usbcore is starting to act "functionally complete" (modulo > > integration issues, notably with the PM framework) it makes sense > > to start cleaning up some of the messier usbcore-to-HCD interfaces. > > > > This patch shows some of how I'm planning to fix one part of that for > > the 2.6.11 kernel: updating usbcore data structures so that the > > internal "struct hcd_dev" can vanish. > > ... > > Your new usb_maxpacket() does an unnecessary byte swap; the maxpacket > values are converted to native byte order when the configuration is > parsed.
That was on my list of things to check, thanks. > You left the hcpriv pointer in usb_device. All of its members have been > superseded except for dev_list; will you move dev_list up a level and get > rid of hcpriv entirely? Turns out that hcd_dev.dev_list can just vanish; it's not actually used for anything. Though the fact that we never got errors there was a good sanity check ... ;) The new sl811-hcd doesn't use dev->hcpriv, and the CRIS code that just joined us in RC2 doesn't seem to either, so this might be a good time to get rid of it. > This looks like a good start. Eventually someone will have to bite the > bullet and merge the usb_bus and usb_hcd structures, plus the > usb_bus_operations and usb_hcd_operations structures. That's going to be > a big job, and there doesn't seem to be any way to break it up into > bite-sized pieces. It can be done a little bit at a time ... for this set of patches, that's not the goal. I was however thinking of some of the ways this should simplify some HCDs. I think UHCI (and SL811) will benefit from not having to build their own representations of the endpoint queues. - Dave ------------------------------------------------------- This SF.Net email is sponsored by: InterSystems CACHE FREE OODBMS DOWNLOAD - A multidimensional database that combines robust object and relational technologies, making it a perfect match for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
