Hi Randy and list, thanks for the extensive reply. I'll try to answer and comment below:
Randy.Dunlap wrote:
Joop Zonnet wrote:
Hi list,
I'd like to know what to do next. Can anyone tell me what I did wrong, please? How should I go about suggesting a patch, a change etc. etc?
wkr,
Gerke
Hi,
I can't help you with testing (no such device), but I'm looking at your file. I have some comments on it, and then I'll try to help you on how to make a patch file from it.
Thanks!
1. Don't change struct { ... } ati_remote_tbl
to a typedef. In general, Linux doesn't like or use
typedefs for structures. It hides too much.
Leave a struct as a struct.
Can you tell me how to use to the same struct then? I'm a bit more into C++ then C. Was that refering the same struct again? I'll give it a try.
2. why did you delete the line(s): set_current_state(TASK_INTERRUPTIBLE); before calling schedule_timeout() ?
I think that is either because I'm using the Mandrake version of the kernel. (I'll try to add my patches to the real kernel) or I'm not up to speed with the latest patches to that kernel.
3. I'm not sure about the changes from usb_kill_urb() to usb_unlink_urb() (since I haven't been keeping up with the USB kernel API very well). Maybe someone else can comment on those.
Same goes for this. I did not touch any of these lines so they must be due to the fact that I use the Mandrake flafour. Should be resolved when I use the real kernel.
4. The key conversion handling looks reasonable to me.
Thanks! About the patch-making: I'll give that a go. I'll let you know more then. Thanks again. wkr, Gerke
------------------------------------------------------- This SF.Net email is sponsored by: InterSystems CACHE FREE OODBMS DOWNLOAD - A multidimensional database that combines robust object and relational technologies, making it a perfect match for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
