On Saturday 20 November 2004 08:52, Linus Torvalds wrote:
> Please don't do it that way. At the very least, don't rely on internal 
> sparse stuff that may change some day. ...

I actually needed something I could use in code that only
works on 2.6.9 kernels, where <linux/compiler.h> doesn't
handle "-Wcontext"; that board isn't on 2.6.10-rc yet, I
needed other version-specific #ifdefs too.


> maybe it's easier to just write the thing out every time, ie
> 
>       int my_hcd_function(...)
>               __releases(ehci->lock)
>               __acquires(ehci->lock)
>       {
>               ...
>       }

Sounds fine to me, and I'll send Greg a patch doing that for
all the HCDs.  I was a bit more concerned with whether that
particular locking policy "should" get changed at some point;
at least, it's one to only adopt with caution.

Thanks for the feedback!

- Dave


-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to